nodebuilder/header: Validate range bounds and export ErrRangeTooLarge in GetRangeByHeight#5052
Open
neyy91 wants to merge 1 commit into
Open
nodebuilder/header: Validate range bounds and export ErrRangeTooLarge in GetRangeByHeight#5052neyy91 wants to merge 1 commit into
neyy91 wants to merge 1 commit into
Conversation
…ounds in GetRangeByHeight Completes the RPC-level range validation started in celestiaorg#4945: - export ErrRangeTooLarge as a well-known sentinel error so clients can detect the limit and paginate - reject reversed/empty ranges early with a clear error instead of relying on the store's internal range check - reject nil 'from' header instead of panicking Closes celestiaorg#4858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #4945, closes #4858.
#4945 added the
MaxRangeRequestSizebound to the RPCGetRangeByHeightpath, but a few points from the issue's design considerations remained open. This PR:ErrRangeTooLargeas a well-known sentinel error so clients can detect the limit and paginate accordinglyinvalid range(...)checkfromheader isnilNo behavioral change for valid requests: the limit value and store semantics (
[from.Height()+1, to)) are untouched.